add support for numbers with thousand spaces (12 345 678) and numbers… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without spaces before metric units (12.3million), add more common abbreviations for million and billion
frootbirb
requested changes
May 13, 2021
There was a problem hiding this comment.
One point of concern - will this handle lists of numbers properly? I'm a little concerned about e.g. "It could be one of 133, 145, or 154". It seems to me that the regex will combine 133 and 145, since it'll ignore "," and then the new regex will join the two three-digit sections. I'm not convinced that that's necessarily a problem, but it should definitely be clearly marked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… without spaces before metric units (12.3million), add more common abbreviations for million and billion, some small style changes
Hi frootbirb 👋🏾
Your recent PR to w2n has some great improvements, thanks for making that PR!
As that's the version of the repo I'll be using myself I also had a go at fixing some other number types I might be encountering and I've PRed them here in case anyone else is interested. The tests (including some new ones I've added) seem to pass and I'm happy to discuss the code or follow up on suggestions