Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#126 Support Zod #127

Merged
merged 14 commits into from
Nov 19, 2022
Merged

#126 Support Zod #127

merged 14 commits into from
Nov 19, 2022

Conversation

su8ru
Copy link
Contributor

@su8ru su8ru commented Nov 18, 2022

close #126

  • split validation page
  • add zod page
  • deprecate class-validator
  • update controller page

validators.ts の挙動が hooks.ts に近いものがあると思ったので Controller-level / Directory-level に分けてみました。不都合あればお知らせください。

@su8ru su8ru self-assigned this Nov 18, 2022
@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
frourio-com ✅ Ready (Inspect) Visit Preview Nov 19, 2022 at 11:51AM (UTC)

@su8ru su8ru force-pushed the feature/126_zod_validator branch from d33630c to 48a1426 Compare November 18, 2022 17:07
@su8ru su8ru marked this pull request as ready for review November 18, 2022 17:07
@su8ru su8ru added the enhancement New feature of the site itself, NOT DOCS label Nov 18, 2022
@su8ru su8ru requested a review from solufa November 18, 2022 17:07
Copy link
Member

@solufa solufa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

早速の対応ありがとうございます

hooks同様に2種類に分けたのは良いアイディア
Zodのアイコンがちょうど良いサイズで挿入されているのがオシャレですね

一部追加と修正確認お願いします

@su8ru su8ru requested a review from solufa November 19, 2022 11:39
Copy link
Member

@solufa solufa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードの対応部分にハイライトあるのいいですね
LGTM

@solufa solufa merged commit 60fc750 into master Nov 19, 2022
@solufa solufa deleted the feature/126_zod_validator branch November 19, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature of the site itself, NOT DOCS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zod対応解説
2 participants