rip off config/locales/helpers, use plain strings instead

It's not worth it, i18n for `submit` tag is dumb and nonflexible: * https://github.com/rails/rails/blob/v4.2.2/actionview/lib/action_view/helpers/form_helper.rb#L1883-L1884 It relies on a model, so you can't define it depending on the current view. Such behavior is very fragile, see: https://github.com/fs/rails-base/pull/287/files#r33035107
fs · Jun 24, 2015 · ed4e559 · ed4e559
1 parent 44782dd
commit ed4e559
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/app/views/users/passwords/edit.html.slim b/app/views/users/passwords/edit.html.slim
@@ -17,7 +17,7 @@
         = f.input :password_confirmation, required: true
 
       .form-actions
-        = f.button :submit
+        = f.button :submit, 'Update password'
 
   .medium-6.columns.end
     = render 'users/shared/links'
diff --git a/app/views/users/registrations/edit.html.slim b/app/views/users/registrations/edit.html.slim
@@ -21,7 +21,7 @@
             required: true
 
       .form-actions
-        = f.button :submit
+        = f.button :submit, 'Update'
 
   .medium-6.columns.end
     h6

diff --git a/app/views/users/registrations/new.html.slim b/app/views/users/registrations/new.html.slim
@@ -22,7 +22,7 @@
         = f.input :password_confirmation, required: true
 
       .form-actions
-        = f.button :submit
+        = f.button :submit, 'Sign up'
 
   .medium-6.columns.end
     = render 'users/shared/links'
diff --git a/config/locales/helpers.en.yml b/config/locales/helpers.en.yml