Request removal of custom fact

[dansajner]

Hi. I really like this module except for the lookup of the redis version. This fact gets executed on every server regardless of its redis intentions and the yum command can be very inefficient. Anyway I can convince you to remove it and just require a version be provided?

[fsalum]

Hi @dansajner, I understand your concerns. We opted for that so the module will be very straightforward to use, without requiring the user to know in advance what version of redis they will be installing since that changes a lot between the different versions of the same OS.

[danieldreier]

I also find this fact to be frustrating. We have redis on a handful of nodes, yet this fact executes on hundreds of systems with every run -- it's extremely inefficient.

[ikryten]

At the very least you could call yum with the '--cacheonly' flag. But I agree, this is really inefficient for a fact.

[danielparks]

It's now causing warnings because it uses :timeout, which is not supported in Puppet 4.

[alex-harvey-z3q]

I'm hitting this issue too. Is this module still being maintained?

[grantholly]

This is also a problem if you have a Redis 3.x deployment as redis_version.rb has a case statement with a default value of nil. Subsequent puppet runs will completely nuke your redis.conf file, like cat /dev/null > /etc/redis.conf kind of behavior because the template redis.conf.erb doesn't contain a block for Redis 3.x.