Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change accessor of Dispatch as a public property in ProgramComponent. #106

Closed
OnurGumus opened this issue Dec 11, 2019 · 1 comment
Closed

Change accessor of Dispatch as a public property in ProgramComponent. #106

OnurGumus opened this issue Dec 11, 2019 · 1 comment
Labels
released: v0.11

Comments

@OnurGumus
Copy link

I think for javascript interop scenarios making the dispatch property of ProgramComponent as public is a good idea.
@Tarmil
Copy link
Member

Tarmil commented Dec 12, 2019

Yeah, at first I made it private because it was an implementation detail and I wasn't sure it would stay there. But now I agree that it should be public.

Tarmil added a commit that referenced this issue Dec 29, 2019
@Tarmil
[#106] Make ProgramComponent.Dispatch getter public
0879d88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released: v0.11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tarmil @OnurGumus