Don't remember a failed shirnk as a last test step.

Otherwise exceptions get lost.
fscheck · Sep 8, 2021 · 52127b5 · 52127b5
1 parent f52f46c
commit 52127b5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/FsCheck/Runner.fs b/src/FsCheck/Runner.fs
@@ -454,7 +454,6 @@ module Runner =
                     config.Runner.OnShrink(result.Arguments, config.EveryShrink)
                     !totalShrinkNb < maxTotalShrinkNb
                 | Shrink _ ->
-                    lastStep := step
                     totalShrinkNb := !totalShrinkNb + 1
                     !totalShrinkNb < maxTotalShrinkNb
                 | Stop -> 
@@ -641,7 +640,7 @@ type Config with
             member __.OnFinished(name,testResult) = 
                 match testResult with
                 | TestResult.Passed _ -> printf "%s" (onFinishedToString name testResult)
-                | _ -> failwithf "%s" (onFinishedToString name testResult)
+                | _ ->  failwithf "%s" (onFinishedToString name testResult)
 
         }
 

diff --git a/tests/FsCheck.Test/Runner.fs b/tests/FsCheck.Test/Runner.fs
@@ -159,7 +159,16 @@ module RunnerInternals =
                            .WithParallelRunConfig(Some { MaxDegreeOfParallelism = Environment.ProcessorCount })
                            .WithArbitrary([typeof<NonNullStringArb>])
 
-        Check.One(config, prop)
+        Check.One(config, prop)   
+
+    [<Fact>]
+    let ```QuickThrowOnFailure should surface exception message``() =
+        try 
+            Check.QuickThrowOnFailure(fun i -> if abs i < 20 then true else failwith "bespoke error message")
+            do failwith "should have thrown an exception!"
+        with e ->
+            Helpers.assertTrue <| e.Message.Contains "with exception:"
+            Helpers.assertTrue <| e.Message.Contains "bespoke error message"
 
 module Runner =
     open RunnerHelper