Caching certificates on memory. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hem inside thread variable. With this thread variable, we store certificate and tll on the memory and if expires at less than current time it invalidates thread variable and reloads it.
|
Thank you both @socio-mehmet and @metekabak. This is merged now and will be released on the next version, today still. |
fschuindt
added a commit
that referenced
this pull request
Aug 15, 2022
fschuindt
added a commit
that referenced
this pull request
Aug 15, 2022
fix: Multi thread caching by reverting PR #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
For every
FirebaseIdToken::Signature.verifyit initiatesFirebaseIdToken::Certificatesinstance and on the initialize level it callsread_certificatesmethod which retrieves certificate from Redis for each call. This is leading to unnecessary Redis call.The problem:
I have refactored
FirebaseIdToken::Signature.verifywhich utilize Thread variables to cache certificates and ttl. With this new setup, there will only one Redis call with the life of ttl. No extra JSON.parseand no extra certificate generation withOpenSSL::X509::Certificate.new