Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Time.current instead Time.now to woks with timezones #34

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

guilhermefeitoza-id
Copy link
Contributor

This step of validation is not working when the server are in a diferente timezone.
There are also a discussion that recommends to not use Time.now and use Time.current instead.
https://discuss.rubyonrails.org/t/time-now-vs-time-current-vs-datetime-now/75183

@fschuindt fschuindt merged commit d671c10 into fschuindt:master Apr 13, 2022
@fschuindt
Copy link
Owner

@guilhermefeitoza-id thank you, Guilherme. It's merged now, and I plan to release a new version soon. Today if possible.

@fschuindt
Copy link
Owner

@guilhermefeitoza-id https://github.com/fschuindt/firebase_id_token/releases/tag/2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants