Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement click, remove argparse #1084

Merged
merged 19 commits into from
Oct 10, 2024
Merged

Implement click, remove argparse #1084

merged 19 commits into from
Oct 10, 2024

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Oct 10, 2024 •
edited
Loading

Fixes #1000

Big refactoring, cleaned up the code less than I'd have liked (especially annotate), but makes future CLI development a lot easier.

  • Added a change log entry in changelog.d/<directory>/.
  • Added self to copyright blurb of touched files.
  • Wrote tests.
  • My changes do not contradict
    the current specification.
  • I agree to license my contribution under the licenses indicated in the
    changed files.

@carmenbianca
Add click dependency
e453cd0 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Create scaffolding for using click CLI
7e81abb 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: convert-dep5
fefd2d4 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: spdx
35caac7 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: supported-licenses
c654aa0 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: download
170f376 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: lint-file
8be8d71 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: lint
f20fd33 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
click: annotate
281fc59 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Remove argparse code
dd744c0 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Use click for pot file generation
74f715f 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Use class-based gettext
18dac76 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Move some functions to comment.py
d17dde5 
This required quite some re-plumbing.

Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Clean up after big refactoring
95d5e3c 
Having refactored argparse to click, this is just cleanup afterwards.

Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Add change log entry
00b281f 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca force-pushed the click branch 4 times, most recently from c0e5708 to e1ae4b4 Compare October 10, 2024 15:22
@carmenbianca
Improve the documentation
df46eaa 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Remove shtab
f31922e 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Fix tests for Windows
8f418ba 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Small fix to if-statement
d34cca8 
Ran across this while debugging something else. Fixing this en passant.

Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca merged commit 3dd5742 into fsfe:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from argparse to click
1 participant
@carmenbianca