Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to LSP (WIP) #210

Merged
merged 24 commits into from
Nov 24, 2019
Merged

Move to LSP (WIP) #210

merged 24 commits into from
Nov 24, 2019

Conversation

juergenhoetzel
Copy link
Collaborator

@juergenhoetzel juergenhoetzel commented Jul 20, 2019

fsautocomplete protocol change to LSP

TODOS:

  • Remove own flycheck/company backends
  • Use Cask instead of non-portable GNU Makefile to automate the package development cycle; development, dependencies, testing, building, packaging
  • Port tests to LSP
  • Update README.md

@MiyamotoAkira
Copy link
Contributor

Anything on which you need help in here?

@juergenhoetzel
Copy link
Collaborator Author

Anything on which you need help in here?

I already have (failing) buttercup based tests on a local branch. I will try to cleanup and push it to this branch this weekend.

Thank you very much for yor help!

@juergenhoetzel
Copy link
Collaborator Author

This pull request is approaching completion.

@Gastove We now use Buttercup for BDT testing and I did a quick and dirty conversion for your tests (using buttercups ert-compability macros).

Currently we are using buttercup helper functions for
ERT-compatibility.
Full Framework version of FSAC is deprecated:
ionide/FsAutoComplete#506
@juergenhoetzel
Copy link
Collaborator Author

I'll fix the CI erros in a new PR to get things moving 🤔.

@juergenhoetzel juergenhoetzel merged commit 14ae882 into fsharp:master Nov 24, 2019
juergenhoetzel added a commit to juergenhoetzel/emacs-fsharp-mode that referenced this pull request Nov 30, 2019
@juergenhoetzel juergenhoetzel mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants