Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue Missing create events on OS X #14 && Clean Path #33

Closed
wants to merge 2 commits into from
Closed

Conversation

zhsso
Copy link
Contributor

@zhsso zhsso commented Aug 17, 2014

fix Issue #14: dirty but it works
Clean Path: Unify the format of Watcher.watches key on Linux and BSD

@nathany
Copy link
Contributor

nathany commented Aug 17, 2014

Thanks @zhsso. I'll test it out shortly.

Do you happen to know the difference between filepath.Clean and path.Clean?

@zhsso
Copy link
Contributor Author

zhsso commented Aug 17, 2014

No, What's the difference?

I saw you use "file path.Clean" in https://github.com/go-fsnotify/fsnotify/blob/master/fsnotify_bsd.go#L371
and when I use Watcher.Add("./") and then mv a b, it occur an error here
https://github.com/go-fsnotify/fsnotify/blob/master/fsnotify_bsd.go#L373
because there is w.watches["./"] but not w.watches["."] in it..

I Think use filepath. Abs() must be a better way

@zhsso
Copy link
Contributor Author

zhsso commented Aug 17, 2014

I read the source of path.Clean() filepath.Clean()
it seems they do the same thing in Linux and BSD
but filepath.Clean() deal with the PathSeparator in windows, and path.Clean() not

Is this the difference?

@nathany
Copy link
Contributor

nathany commented Aug 17, 2014

Thanks for looking into it. Sounds like we're on the right path. 😜

I'm going to tackle #34 before I merge this in and do a new release later today.

@nathany
Copy link
Contributor

nathany commented Aug 17, 2014

@zhsso I forgot to mention

Contributors retain their copyright, so we need you to fill out a short form before we can accept your contribution: Google Individual Contributor License Agreement.

Have you already signed the Go CLA?

nathany added a commit that referenced this pull request Aug 17, 2014
ref #33

closes #14
nathany added a commit that referenced this pull request Aug 17, 2014
nathany added a commit that referenced this pull request Aug 17, 2014
@zhsso
Copy link
Contributor Author

zhsso commented Aug 18, 2014

I signed it Electronically just a moment ago 😊

@nathany
Copy link
Contributor

nathany commented Aug 18, 2014

Thanks very much @zhsso.

@nathany nathany closed this Aug 18, 2014
@zhsso zhsso deleted the OSX branch August 18, 2014 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants