-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue Missing create events on OS X #14 && Clean Path #33
Conversation
Thanks @zhsso. I'll test it out shortly. Do you happen to know the difference between |
No, What's the difference? I saw you use "file path.Clean" in https://github.com/go-fsnotify/fsnotify/blob/master/fsnotify_bsd.go#L371 I Think use filepath. Abs() must be a better way |
I read the source of path.Clean() filepath.Clean() Is this the difference? |
Thanks for looking into it. Sounds like we're on the right path. 😜 I'm going to tackle #34 before I merge this in and do a new release later today. |
@zhsso I forgot to mention Contributors retain their copyright, so we need you to fill out a short form before we can accept your contribution: Google Individual Contributor License Agreement. Have you already signed the Go CLA? |
I signed it Electronically just a moment ago 😊 |
Thanks very much @zhsso. |
fix Issue #14: dirty but it works
Clean Path: Unify the format of Watcher.watches key on Linux and BSD