Slack webhook username not from #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 5.15.4
Basing this off local testing and the slack api node sdk https://github.com/slackapi/node-slack-sdk/blob/e771e3c6fb346c42f6c86baba76223485c5c1024/packages/webhook/src/IncomingWebhook.ts#L92
Changed the namespace because the script I was testing with already had Fake added and I wasn't sure if #r-ing SlackNotification.fs into the script would mess up if they were in the same namespace. So I changed it and now I am deleting it.
|
I didn't see any integration tests for this ( probably because you don't have a slack server hanging around for testing ). I tested this manually and it worked. I am not sure what other information you might need for this. |
|
@mastion thanks looks good to me. Usually we add unit-tests for bugfixes but in this case I'm not sure what we could test so... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the username of an incoming slack message was not working. It was due to an incorrectly named field. Instead of
Fromthe field should beUsername.Also modified the documentation
No issue for this. I brought it up in the gitter.
TODO
Feel free to open the PR and ask for help
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "Modules" menu, edit
help/templates/template.cshtml, linking to the API-reference is fine.(if new module) the module is in the correct namespace
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)Fake 5 API guideline is honored