Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat non csproj files as nuspec files #767

Conversation

MaximilianLackaw
Copy link

Currently nuspec files must have a .nuspec file extension to be treated as valid nuspec templates. We have nuspec files without this extension which no longer work with up to date versions. The only reason why this distinction exists, is to cover .csproj files. So our suggestion is to just look for the .csproj file extension.

@forki
Copy link
Member

forki commented Apr 24, 2015

I'd like to accept this change, but I assume yoo need to consider vb, F# and other project types.

Question: why don't you go with the nuget default?

@ilkerde
Copy link
Contributor

ilkerde commented Apr 24, 2015

@forki Look at the change. It's just reversing the defaults. @MaximilianLackaw did not care about whatsoever project files are going to be supported. I think it was @jamescrowley only going for .csproj in #644.

@forki
Copy link
Member

forki commented Apr 24, 2015

I was talking about https://github.com/fsharp/FAKE/pull/767/files#diff-88b397b8b3d4d92a120c4eb5fce2b2d5R236

it introduces the new constant "csproj".

@forki
Copy link
Member

forki commented Apr 24, 2015

nice.

@ilkerde
Copy link
Contributor

ilkerde commented Apr 24, 2015

I was talking about that as well. Maybe I can't read F#, but the match expression reads to me "If file ends with csproj, please do some magic, otherwise treat it as a nuspec template file". Isn't this exactly what #644 was attempting to but went for the inverted logic "if it ends with nuspec, then treat it as a nuspec template file, otherwise do some magic".

@ilkerde
Copy link
Contributor

ilkerde commented Apr 24, 2015

So @MaximilianLackaw fixed it anyway. Forget about my nitpicking.

@forki
Copy link
Member

forki commented Apr 24, 2015

yep. but my point was: we should do the magic for all project types.

forki added a commit that referenced this pull request Apr 24, 2015
…as-nuspec-files

Treat non csproj files as nuspec files
@forki forki merged commit 24c5af6 into fsprojects:master Apr 24, 2015
@forki
Copy link
Member

forki commented Apr 24, 2015

Just out of curiosity: why don't you go for *.nuspec?

@ilkerde
Copy link
Contributor

ilkerde commented Apr 24, 2015

Well you know it might be that template files are going to be packaged within nugets but may not be suffixed .nuspec because they would be omitted by the pack command.

@MaximilianLackaw MaximilianLackaw deleted the treat-non-csproj-files-as-nuspec-files branch April 24, 2015 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants