Refactor SquirrelHelper #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to specify a custom icon for the created Setup.exe-File.
* LoadingGif- and BootstrapperExe-Parameter: The space between the parameter name and the value caused Squirrel to ignore the value. * Don't append the /a-Parameter twice
This allows us to pass paths which contain spaces to Squirrel.exe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually wanted to add the
--setupIcon-Parameter only (which isn't mentioned in the docs of Squirrel), but ended up reworking the existing code a bit, because of some issues (e. g. Squirrel ignoring the--loadingGif-Parameter).Tell me if I should split this PR up, otherwise this is ready to merge.