refact: moving websockets code to .Shared to prepare for client impl. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to implement the client part now. It's useful to share contract-related code between client and server implementations.
valbers
commented
Nov 21, 2024
xperiandri
reviewed
Nov 22, 2024
| @@ -1,6 +1,6 @@ | |||
| module internal FSharp.Data.GraphQL.Server.AspNetCore.GraphQLSubscriptionsManagement | |||
|
|
|||
| open FSharp.Data.GraphQL.Server.AspNetCore.WebSockets | |||
| open FSharp.Data.GraphQL.Shared.Websockets | |||
There was a problem hiding this comment.
Suggested change
| open FSharp.Data.GraphQL.Shared.Websockets | |
| open FSharp.Data.GraphQL.Shared.WebSockets |
|
|
||
| open System.Collections.Generic | ||
|
|
||
| type Output = IDictionary<string, obj> |
There was a problem hiding this comment.
I would put NameValueLookup into this file
| @@ -0,0 +1,4 @@ | |||
| namespace FSharp.Data.GraphQL.Shared.Websockets | |||
There was a problem hiding this comment.
Suggested change
| namespace FSharp.Data.GraphQL.Shared.Websockets | |
| namespace FSharp.Data.GraphQL.Shared.WebSockets |
| @@ -1,10 +1,9 @@ | |||
| namespace FSharp.Data.GraphQL.Server.AspNetCore.WebSockets | |||
| namespace FSharp.Data.GraphQL.Shared.Websockets | |||
There was a problem hiding this comment.
Suggested change
| namespace FSharp.Data.GraphQL.Shared.Websockets | |
| namespace FSharp.Data.GraphQL.Shared.WebSockets |
There was a problem hiding this comment.
I would put InvalidWebsocketMessageException into this file and name it WebSockets.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to implement the client part now. It's useful to share contract-related code between client and server implementations.