FSharp.Data.Html suggested change to enable people to use the html parser without hiding representation without having to hack the code itself. #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng representation without having to hack the code itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to use the html parsing DSL without the encumbering that active pattern brings in terms of using those to "avoid breaking changes" in the DU definitions, costing in terms of tooling and ways to do the matching using it.
For now, this is just so people can make their own build by flipping a tag in the fsproj, but we may consider having something similar to https://github.com/fsprojects/FSharp.Data.SqlClient/blob/c6e48a47eb1d64c7de7596bae3cb50a548592357/src/SqlClient/DataTable.fs#L10 as default, and provide the same package with "HIddenRepresentation" suffix to the nuget package name, for those that feel their code will be more resilient to this library changing things.
related: #1227, #1102, fsharp/fslang-suggestions#1341