Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar improvements #383

Merged
merged 8 commits into from
Feb 13, 2024
Merged

Sidebar improvements #383

merged 8 commits into from
Feb 13, 2024

Conversation

abc013
Copy link
Contributor

@abc013 abc013 commented Aug 16, 2023

Closes #353.

Furthermore, this PR streamlines the minute and information page sidebar layout (see second commit) and also adds empty date or editor handling.

I was unable to test some of the changes, specifically those about the minute sidebar. Before approving, please check whether everything looks as expected. I'm investigating why minute pages don't work (even on main) on my local setup.

@abc013 abc013 requested a review from jeriox August 16, 2023 15:12
@jeriox jeriox requested a review from frcroth August 16, 2023 15:30
@frcroth
Copy link
Contributor

frcroth commented Sep 1, 2023

It would be helpful to have a list of changes that are supposed to work to test them (if automated tests are not an option).

myhpi/core/templates/core/sidebar.html Show resolved Hide resolved
myhpi/core/templates/core/minutes.html Outdated Show resolved Hide resolved
myhpi/core/templates/core/minutes.html Show resolved Hide resolved
@jeriox
Copy link
Contributor

jeriox commented Sep 12, 2023

additional idea: display a warning banner or some indication in the sidebar for pages that are a draft (similar to the exclamation mark in the list)

@abc013 abc013 force-pushed the feature/353-display-page-visibility branch from cc4a324 to 4e03473 Compare December 20, 2023 16:40
@coveralls
Copy link

coveralls commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7885310787

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.372%

Totals Coverage Status
Change from base Build 7864580755: 0.0%
Covered Lines: 1274
Relevant Lines: 1713

💛 - Coveralls

@abc013
Copy link
Contributor Author

abc013 commented Dec 20, 2023

@jeriox good idea. I added it in e56ed7d:
image

@jeriox
Copy link
Contributor

jeriox commented Dec 21, 2023

@abc013 is the description of the PR still correct or could you test your changes locally in the meantime?

myhpi/core/templates/core/information_page.html Outdated Show resolved Hide resolved
myhpi/locale/de/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
myhpi/core/templates/core/minutes.html Outdated Show resolved Hide resolved
@abc013
Copy link
Contributor Author

abc013 commented Dec 22, 2023

@abc013 is the description of the PR still correct or could you test your changes locally in the meantime?

I would say I was able to test most of it, but would be happy to have someone with a proper database looking over it. My test minute pages are quite empty. :D

@abc013 abc013 force-pushed the feature/353-display-page-visibility branch 2 times, most recently from 5e59e94 to 639e9b5 Compare December 22, 2023 16:57
@frcroth
Copy link
Contributor

frcroth commented Jan 2, 2024

I would say I was able to test most of it, but would be happy to have someone with a proper database looking over it. My test minute pages are quite empty. :D

With #444 merged, you should now be able to create somewhat longer minutes automatically.

@abc013 abc013 requested review from frcroth and jeriox January 25, 2024 15:29
@frcroth frcroth mentioned this pull request Jan 27, 2024
@jeriox
Copy link
Contributor

jeriox commented Feb 7, 2024

grafik

@abc013 abc013 force-pushed the feature/353-display-page-visibility branch from dbe4ed3 to 210be98 Compare February 13, 2024 10:45
@abc013
Copy link
Contributor Author

abc013 commented Feb 13, 2024

grafik

Should be fixed via this PR

@abc013 abc013 merged commit 6ea2cd8 into main Feb 13, 2024
8 checks passed
@abc013 abc013 deleted the feature/353-display-page-visibility branch February 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Display page visibility on pages
4 participants