-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not update names from OIDC #393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely happy approving this, since one of the big painpoints in 1327 was the constant stream of problems of people who dropped the student from their email (becoming phd students)
I discussed this with @dasGoogle and we thought that this PR shouldn't change anything about that, as the user with the changed mail adress wouldn't be found/authenticated in the first place |
We will have to rewrite the whole authentication and user matching routine as soon as the new SSO is rolled out. There still is the discussion of whether to introduce an FSR SSO or directly attach to the new HPI SSO which will provide per-user UUIDs that should be static and can be used as an identifier instead of the email address. |
Having talked to @lukasrad02 about this: The sub currently is firstname.lastname which would be static over an email address change. So there might be some value in still updating the email address on every sign in. |
So update email address but do not update names? Would be fine with me. Also, add a comment with a link to this PR in the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the failing test so that it checks that email is changed and that name is not chnaged.
b82f6c0
to
98f1036
Compare
98f1036
to
7c0dcd6
Compare
closes #392