Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests #395

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Add more tests #395

merged 10 commits into from
Oct 16, 2023

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Oct 15, 2023 •
edited
Loading

Increases coverage by 10%.

Also fixes 2 bugs:

  • Markdown headline preprocessor did not stop at level 5
  • The poll implementation allowed users to submit poll choices for any poll

@frcroth frcroth changed the title Add markdown extension tests Add more tests Oct 15, 2023
@frcroth frcroth marked this pull request as ready for review October 15, 2023 13:22
@frcroth frcroth requested a review from jeriox October 15, 2023 13:54
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6539494617

  • 242 of 242 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+12.6%) to 74.507%
Totals Coverage Status
Change from base Build 6526029391: 12.6%
Covered Lines: 1248
Relevant Lines: 1675
💛 - Coveralls

@frcroth frcroth merged commit 7b485d6 into fsr-de:main Oct 16, 2023
8 checks passed
@frcroth frcroth deleted the moar-tests branch October 16, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frcroth @coveralls @jeriox