-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to keycloak as IDP #422
Conversation
Can you provide test setup instructions? |
My testing looked as follows:
|
As we now have set up some basic group management in our Keycloak, I'd suggest we also integrate that into this PR. @frcroth In case you want to test the setup yourself, please contact me or @lukasrad02 directly so we can give you some testing credentials. |
@dasGoogle yep that was the plan, can you provide me with some infos on how the groups look in the OIDC claim or do I have to figure that out on my own? :D (would probably be good to write that down somewhere for the future anyways) |
There will most likely (not Setup yet) a claim called "role", containing an array of arbitrary strings, each of which being a unique identifier for a group. @lukasrad02 and I expect that this mapping of ID to actual myHPI group would happen based on an attribute on each myHPI Group. |
07924eb
to
a2a0ced
Compare
After another discussion with @dasGoogle we decided against a separate identifier for the groups and will instead use the group name directly (e.g. "student"). We could change our templates to capitalize the group names for the UI |
Pull Request Test Coverage Report for Build 7116695497
💛 - Coveralls |
Migrates users to use the new sub from OIDC claims
closes #336