Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open external links in another tab and add icon showing that it's an external link #437

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Open external links in another tab and add icon showing that it's an external link #437

merged 1 commit into from
Feb 13, 2024

Conversation

abc013
Copy link
Contributor

@abc013 abc013 commented Dec 20, 2023

Closes #212.

@abc013 abc013 requested a review from frcroth December 20, 2023 19:10
@coveralls
Copy link

coveralls commented Dec 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7887846092

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.477%
Totals Coverage Status
Change from base Build 7886409057: 0.0%
Covered Lines: 1281
Relevant Lines: 1720
💛 - Coveralls

jeriox
jeriox reviewed Dec 21, 2023
View reviewed changes
myhpi/core/markdown/extensions.py Outdated Show resolved Hide resolved
myhpi/core/templatetags/core_extras.py Show resolved Hide resolved
myhpi/core/markdown/extensions.py Outdated Show resolved Hide resolved
myhpi/templates/footer.html Outdated Show resolved Hide resolved
@abc013 abc013 force-pushed the feature/212-open-external-links-in-new-tab-by-default branch from 630be65 to 6085e48 Compare February 13, 2024 14:15
@abc013
Copy link
Contributor Author

abc013 commented Feb 13, 2024

Updated.

@abc013 abc013 self-assigned this Feb 13, 2024
@abc013 abc013 force-pushed the feature/212-open-external-links-in-new-tab-by-default branch 2 times, most recently from a8b5cb2 to 06673b3 Compare February 13, 2024 20:12
@abc013 abc013 force-pushed the feature/212-open-external-links-in-new-tab-by-default branch from 06673b3 to 555aa37 Compare February 13, 2024 20:18
@jeriox jeriox merged commit 620e61a into main Feb 13, 2024
8 checks passed
@jeriox jeriox deleted the feature/212-open-external-links-in-new-tab-by-default branch February 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

@frcroth frcroth Awaiting requested review from frcroth

Assignees

@abc013 abc013

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open external links in new tab by default
3 participants
@abc013 @coveralls @jeriox