Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker images with labels #456

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Jan 3, 2024

@frcroth frcroth requested a review from jeriox January 3, 2024 19:22
@coveralls
Copy link

coveralls commented Jan 3, 2024

Pull Request Test Coverage Report for Build 7464814675

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.402%

Totals Coverage Status
Change from base Build 7404061654: 0.0%
Covered Lines: 1276
Relevant Lines: 1715

💛 - Coveralls

@jeriox
Copy link
Contributor

jeriox commented Jan 4, 2024

What is the metadata-action used for? (comparing against https://github.com/ephios-dev/ephios/blob/main/.github/workflows/docker.yml). And you probably need the permission stuff to write packages as well

@frcroth
Copy link
Contributor Author

frcroth commented Jan 4, 2024

What is the metadata-action used for? (comparing against ephios-dev/ephios@main/.github/workflows/docker.yml). And you probably need the permission stuff to write packages as well

Ok, the ephios action looks good. How do you use it? Do you create releases via github and then manually start the workflow or do you create tags via git locally and then push them to trigger it? I think it would be best if it automatically ran on release (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release) but I'm not sure if we have the metadata available there.

@frcroth frcroth linked an issue Jan 4, 2024 that may be closed by this pull request
@jeriox
Copy link
Contributor

jeriox commented Jan 4, 2024

We create releases in the GitHub webinterface, and this automatically triggers the workflow and creates the correctly tagged packages (https://github.com/ephios-dev/ephios/pkgs/container/ephios)

@frcroth
Copy link
Contributor Author

frcroth commented Jan 5, 2024

We create releases in the GitHub webinterface, and this automatically triggers the workflow and creates the correctly tagged packages (ephios-dev/ephios/pkgs/container/ephios)

Ok, so just replace the current action with the ephios workflow file?

@frcroth
Copy link
Contributor Author

frcroth commented Jan 9, 2024

@jeriox

@frcroth frcroth changed the title Add action for pushing docker labels Publish docker images with labels Jan 10, 2024
@frcroth frcroth merged commit e603fba into fsr-de:main Jan 10, 2024
8 checks passed
@frcroth frcroth deleted the add-action-for-pushing-docker-labels branch January 10, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tag docker images with versions Skip docker image push on dependency update
3 participants