Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show preview when it does not make sense #487

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Don't show preview when it does not make sense #487

merged 4 commits into from
Feb 13, 2024

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Feb 13, 2024

Closes #460

See also wagtail/wagtail#5670

@frcroth frcroth requested a review from jeriox February 13, 2024 10:25
@coveralls
Copy link

coveralls commented Feb 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7886350482

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.477%
Totals Coverage Status
Change from base Build 7886295097: 0.03%
Covered Lines: 1281
Relevant Lines: 1720
💛 - Coveralls

@frcroth frcroth merged commit f53767b into fsr-de:main Feb 13, 2024
8 checks passed
@frcroth frcroth deleted the dont-show-preview branch February 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing templates for first and second level menu items may cause internal server errors
3 participants
@frcroth @coveralls @jeriox