Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around missing image class in translations bug #500

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Work around missing image class in translations bug #500

merged 1 commit into from
Feb 13, 2024

Conversation

abc013
Copy link
Contributor

@abc013 abc013 commented Feb 13, 2024 •
edited
Loading

Closes #483.

Further explanations:

  • Relevant code is in myhpi/core/markdown/fields.py
  • Specifically: html2text drops all css classes when converting html back to md
  • Sadly, there is no quick workaround to get those classes back

@abc013 abc013 linked an issue Feb 13, 2024 that may be closed by this pull request
Images bleed into sidebar in translated pages #483
Closed
@jeriox jeriox force-pushed the fix/483-images-bleed-into-sidebar-in-translated-pages branch from 35697a5 to ac8f817 Compare February 13, 2024 20:34
@jeriox jeriox enabled auto-merge (rebase) February 13, 2024 20:34
@jeriox jeriox merged commit 8bc30c7 into main Feb 13, 2024
8 checks passed
@jeriox jeriox deleted the fix/483-images-bleed-into-sidebar-in-translated-pages branch February 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images bleed into sidebar in translated pages
2 participants
@abc013 @jeriox