-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search results page #557
Conversation
Ping @jeriox @lukasrad02 for your suggestions |
I think you dropped the date (#492), or is your example not a protocol? I think we should definetly include that. Could you also provide a screenshot with multiple results? With the current layout I suspect that it could be hard to visually distinguish between different results as they are not as uniform as before |
I like it |
another suggestion from #345: restrict search to specific areas of the page (pages/minutes/even specific minutes lists or respective groups?) -> can also be a separate issue if you don't want to implement it in this PR |
|
||
@register.filter(name="highlight_query_markdown") | ||
# select 3 lines around first match and highlight query match | ||
def highlight_query(content, search_query, surrounding_lines=1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems quite complex, maybe it could be tested?
* Order search results by date * add a better preview for results * Highlight matches in title as well * Limit maximum number of lines if query is not in markdown
This is a PR to track some improvements to the search page. This includes proper sorting, a better content preview and maybe additional filters.