Ensure correct overlay order of content, toc and side panel #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvanVerhoeven
changed the title
|
@abc013 Review pls <3 |
SilvanVerhoeven
force-pushed
the
fix-abbreveation-overlay
branch
from
b535b70
to
5e41072
Compare
|
@jeriox could you push the ok button pls? :) |
jeriox
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #587
Known limitation: The sidebar can overlay the toc button. This can become apparent on mobile if the sidebar/footer is so long, that the user could scroll past that point. This is not expected to be the case often. Future releases may want to move more content into offcanvas panels (like already done with the toc), which reduces the height of the sidebar further.