Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design for polls #592

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

SilvanVerhoeven
Copy link
Collaborator

Closes #588

grafik

@SilvanVerhoeven
Copy link
Collaborator Author

SilvanVerhoeven commented Jul 30, 2024

@jeriox base.html and poll_base.html are rather similar now. To what degree should both be merged?

@SilvanVerhoeven SilvanVerhoeven self-assigned this Jul 30, 2024
@jeriox
Copy link
Contributor

jeriox commented Jul 30, 2024

@jeriox base.html and poll_base.html are rather similar now. To what degree should both be merged?

The base_poll introduces some logic with respect to voting periods etc. I currently don't see how we could merge that with the base.html without duplicating the logic into the different poll types. If you have an idea feel free to make a suggestion, less code is always better :D

@SilvanVerhoeven
Copy link
Collaborator Author

@jeriox base.html and poll_base.html are rather similar now. To what degree should both be merged?

The base_poll introduces some logic with respect to voting periods etc. I currently don't see how we could merge that with the base.html without duplicating the logic into the different poll types. If you have an idea feel free to make a suggestion, less code is always better :D

It might be reasonable to introduce a sidebar_base and fullwidth_base or similar, both based on base.html. sidebar_base would combine the outer tags and page title from information_page, poll_base and similar, while fullwidth_base serves e.g. minutes_list.

Additionally, the page title markup could be moved into its own template

@SilvanVerhoeven SilvanVerhoeven mentioned this pull request Jul 30, 2024
2 tasks
@SilvanVerhoeven SilvanVerhoeven enabled auto-merge (rebase) July 30, 2024 11:38
@SilvanVerhoeven SilvanVerhoeven merged commit 324c882 into fsr-de:main Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Responsive layout for poll pages
2 participants