-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly handle local files with colons (:
) in name
#1452
Conversation
Looks like fsspec.generic.py:_resolve_fs should not pass a list to split_protocol |
@martindurant looks like the CI is failing due to https://github.com/fsspec/filesystem_spec/blob/master/fsspec/core.py#L516 being called with a list argument. This method should only take strings, so I guess this exposed another issue. Being called with a list was previously bypassing the |
Apparently windows does not support |
I'll double check in our end that this fixes things and I'll mark this PR as ready. Update: Looks good! |
It being Thursday evening, a release this week is unlikely. |
Could a release come before Dec 13th? That is what matters for decision making. |
Yes, I guarantee it. Ping me on Monday if I haven't done it yet. |
@martindurant ping! |
Fixes #1447