Add pickling support to HttpError class
#571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HttpError class was updated to include support for pickling. A new private attribute _error_response was added for potential pickle use, and the __reduce__ method was added to deconstruct the HttpError when pickled. This update allows HttpErrors to be serialized and deserialized.
tasansal
changed the title
HttpError class
|
I suppose a test would be nice |
|
True, will write one and push. |
added 3 commits
July 25, 2023 13:33
Two new tests were added to the 'test_retry.py' script for improving the reliability and robustness of the code. The 'test_pickle_serialization' test was implemented to check the pickle serialization process of the HttpError class. The 'test_multiprocessing_error_handling' was added to validate how the application handles exceptions when running on multiple processes.
|
@martindurant I think its good to go now. Can you do one more review? |
|
@martindurant would it be possible to release this soon? Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpErrorclass was updated to include support for pickling. A new private attribute_error_responsewas added for potential pickle use, and the__reduce__method was added to deconstruct the HttpError when pickled. This update allows HttpErrors to be serialized and deserialized, i.e. in the case of multiprocessing use.Closes #570.