Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: allow configuring smb port via env var #314

Merged
merged 1 commit into from
Nov 21, 2024
Merged

tests: allow configuring smb port via env var #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions upath/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ def smb_container():
container = "fsspec_smb"
stop_docker(container)
cfg = "-p -u 'testuser;testpass' -s 'home;/share;no;no;no;testuser'"
port = 445
port = int(os.environ.get("UPATH_TESTS_SMB_PORT", "445"))
img = f"docker run --name {container} --detach -p 139:139 -p {port}:445 dperson/samba" # noqa: E231 E501
cmd = f"{img} {cfg}"
try:
Expand All @@ -448,7 +448,7 @@ def smb_container():

@pytest.fixture
def smb_url(smb_container):
smb_url = "smb://{username}:{password}@{host}/home/"
smb_url = "smb://{username}:{password}@{host}:{port}/home/"
smb_url = smb_url.format(**smb_container)
return smb_url

Expand Down