timeTrackingController - fix for case when no events to be saved

fszwedo · Jul 2, 2023 · 29e72b0 · 29e72b0
1 parent 40d7fd5
commit 29e72b0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "yargs": "^17.6.2"
   },
   "engines": {
-    "node": "14.x"
+    "node": "16.x"
   },
   "devDependencies": {
     "@babel/core": "^7.20.12",

diff --git a/src/controllers/timeTrackingController.ts b/src/controllers/timeTrackingController.ts
@@ -34,7 +34,6 @@ export default class TimeTrackingController {
 
         //for each audit log - get events that are related to time tracking
         const timeTrackingEventsToSave: TimeTrackingEvent[] = [];
-
         if (newAuditLogs.length > 0) {
             newAuditLogs.forEach(log => {
                 const timeSpentEvent = log.events.find(ev => ev.field_name == TICKET_CUSTOM_FIELDS.TIME_SPENT.toString());
@@ -58,13 +57,14 @@ export default class TimeTrackingController {
             let savedEvents;
             try {
                 savedEvents = await this.timeTrackingEventService.saveTimeTrackingEvents(timeTrackingEventsToSave);
+                if (timeTrackingEventsToSave.length > 0)
+                    return {
+                        lastEventDate: timeTrackingEventsToSave.at(-1).created_at,
+                        numberOfNewEventsSaved: savedEvents.success.length
+                    };
             } catch (error) {
                 console.log(error)
             }
-            return {
-                lastEventDate: timeTrackingEventsToSave.at(-1).created_at,
-                numberOfNewEventsSaved: savedEvents.success.length
-            };
         }
         return "No data to be saved!"
     }