Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fs time tracking #31

Merged
merged 10 commits into from
Jul 2, 2023
Merged

Fs time tracking #31

merged 10 commits into from
Jul 2, 2023

Conversation

fszwedo
Copy link
Owner

@fszwedo fszwedo commented Jun 9, 2023

Time tracking handling feature:

  • 'connector' to extract Zendesk time tracking events
  • endpoints to get/download tracking event exports

fszwedo
fszwedo commented Jun 9, 2023
View reviewed changes
Copy link
Owner Author

@fszwedo fszwedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my own code, seems ready for review

@fszwedo fszwedo requested a review from Xtrems876 June 20, 2023 12:16
rajashree27
rajashree27 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@rajashree27 rajashree27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I browsed through the code in general and everything looked fine for me - had two questions that I posted as comments but in general couldn't find any issues with code structure or general improvements :)

utilities/saveTimeTrackingEvents.ts Show resolved Hide resolved
src/controllers/timeTrackingController.ts Outdated Show resolved Hide resolved
@fszwedo fszwedo merged commit 703f57c into main Jul 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajashree27 rajashree27 rajashree27 approved these changes

@yagi527 yagi527 Awaiting requested review from yagi527

@Xtrems876 Xtrems876 Awaiting requested review from Xtrems876

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fszwedo @rajashree27