Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes encoding based on advice from @ftao #19

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Fixes encoding based on advice from @ftao #19

merged 2 commits into from
Jan 11, 2018

Conversation

benjaoming
Copy link
Collaborator

I hope this does the trick.

The unfortunate issue is that it seems quite likely that using ipconfig for localized Windows isn't the way forward, but regardless, it's nice to have functional subprocess output and a non-crashing API :)

#17

@benjaoming
Copy link
Collaborator Author

This fails on Python 3, will have a look tomorrow... enough encoding for one day

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #19 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #19      +/-   ##
=========================================
- Coverage   86.27%   86.2%   -0.07%     
=========================================
  Files           4       4              
  Lines         204     203       -1     
=========================================
- Hits          176     175       -1     
  Misses         28      28
Impacted Files Coverage Δ
src/ifcfg/parser.py 85.4% <ø> (ø) ⬆️
src/ifcfg/__init__.py 93.33% <100%> (ø) ⬆️
src/ifcfg/tools.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddb52e...7b8eece. Read the comment docs.

@benjaoming
Copy link
Collaborator Author

@ftao Sorry about the stress from my side, we are fixing a very annoying bug, so I will merge+release this ASAP.

It should fix crashes, although it does not address to problems with localized cmd.exe -- so I will target another release for this purpose, possibly abandoning ipconfig all together.

@benjaoming benjaoming merged commit 3476547 into ftao:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants