Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Improve BoNeMEAL regarding load time with large databases and multiple servers #53

Closed
Slind14 opened this issue Aug 6, 2015 · 12 comments
Assignees
Labels

Comments

@Slind14
Copy link

Slind14 commented Aug 6, 2015

https://i.imgur.com/OwbbK1v.png
https://i.imgur.com/WlmxUeN.png
https://i.imgur.com/C2Bcd6e.png

@ftbastler ftbastler added the bug label Sep 10, 2015
@ftbastler ftbastler self-assigned this Sep 10, 2015
@ftbastler
Copy link
Owner

Thanks for your report. Will look into it.

@thu2468
Copy link

thu2468 commented Nov 16, 2015

Can you please fix this

@ftbastler
Copy link
Owner

How many server do you have added to BoNeMEAL?

@Slind14
Copy link
Author

Slind14 commented Dec 6, 2015

1 with a few thousand bans

@ftbastler
Copy link
Owner

Ah.. okay. I will try to optimize this by using cron tasks to get stuff done.

@Slind14
Copy link
Author

Slind14 commented Dec 7, 2015

looking forward to it

@ftbastler ftbastler changed the title Admin Panel requiring +30 seconds to load, not possible to use without increasing the 30 sec limit Improve BoNeMEAL regarding load time with large databases and multiple servers Dec 10, 2015
@ftbastler ftbastler changed the title Improve BoNeMEAL regarding load time with large databases and multiple servers Improve BoNeMEAL regarding load time with large databases and multiple servers Dec 10, 2015
@oranges13
Copy link
Contributor

My PR #96 introduces some performance updates that should fix this issue.

@Slind14
Copy link
Author

Slind14 commented Dec 6, 2018

Looking good, thank you @oranges13
The only view which is still running into this issue is "Players".

@oranges13
Copy link
Contributor

Depending on how many players you have, fixing that issue may require moving to server-side datatables. That's not impossible, just this app is written with an older version of Laravel then what it currently supports. Definitely in the list of things I want to do, but would be a significant rewrite. I will see if there's anything else I can do to make it more efficient in the mean time.

@Slind14
Copy link
Author

Slind14 commented Dec 7, 2018

Great, thank you. The bm_players table has +400k records.

@oranges13
Copy link
Contributor

Holywow, yeah -- I'm going to keep developing. As there's been no response from @ftbastler on the PR's I'm going to move to my fork: https://github.com/oranges13/BoNeMEAL

I released all the changes I have made so far as 1.2.0. I need to integrate the commit you referenced above, but I will make a new release for that shortly.

@Slind14
Copy link
Author

Slind14 commented Dec 7, 2018

Great, thank you :)
Feel free to cherry pick it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants