This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Add interface to view all warnings and all player notes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use eager loading to prevent time out on large queries for activeWarnings, activeMutes and activeBans * Use `forelse` with empty instead of nested if statements on activePunishments.blade * Performance improvements on dashboard (eager loading, fewer loops, counting in the database rather than iterating through a result set) * This should improve or fix ftbastler#53, ftbastler#73 * TODO: Interface to display all player notes
* Modify admin javascript to allow per-view configurable Datatables (for sorting) * Added index for viewing all notes on all players * Added translations for new interface * Fixed whitespace in files
|
This is great, thank you. The Dashboard loads now. The issue only persists for the Players view. |
|
here is one small issue we encountered, not sure if related: MineYourMind@4ceb2fb |
|
Thanks @Slind14 , fixing that can't hurt, as well. I'll add it to the PR branch. I will also look into the player loading problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface to view all player warnings and all player notes. Fixing #94
Also adds some performance improvements that should solve #73 and other similar errors.