Merge pull request #499 from fthomas/topic/improve-unsafeFrom

Improve performance of RefinedType#unsafeFrom

modules/benchmark/src/main/scala/eu/timepit/refined/benchmark/PosIntBenchmark.scala

@@ -0,0 +1,14 @@
+package eu.timepit.refined.benchmark
+
+import eu.timepit.refined.types.numeric.PosInt
+import java.util.concurrent.TimeUnit
+import org.openjdk.jmh.annotations.{Benchmark, BenchmarkMode, Mode, OutputTimeUnit}
+
+@BenchmarkMode(Array(Mode.AverageTime))
+class PosIntBenchmark {
+
+  @Benchmark
+  @OutputTimeUnit(TimeUnit.NANOSECONDS)
+  def unsafeFrom_1: Any =
+    PosInt.unsafeFrom(1)
+}

modules/core/shared/src/main/scala/eu/timepit/refined/api/RefinedType.scala

@@ -22,12 +22,15 @@ trait RefinedType[FTP] extends Serializable {
 
   final def refine(t: T): Either[String, FTP] = {
     val res = validate.validate(t)
-    if (res.isPassed) Right(alias(refType.unsafeWrap(t)))
+    if (res.isPassed) Right(refType.unsafeWrap(t).asInstanceOf[FTP])
     else Left(validate.showResult(t, res))
   }
 
-  final def unsafeRefine(t: T): FTP =
-    refine(t).fold(err => throw new IllegalArgumentException(err), identity)
+  final def unsafeRefine(t: T): FTP = {
+    val res = validate.validate(t)
+    if (res.isPassed) refType.unsafeWrap(t).asInstanceOf[FTP]
+    else throw new IllegalArgumentException(validate.showResult(t, res))
+  }
 }
 
 object RefinedType {

notes/0.9.1.markdown

@@ -6,8 +6,14 @@
   if a `String` is a parsable `Byte`, `Short`, or `Float`.
   ([#492][#492] by [@sh0hei][@sh0hei])
 
+### Changes
+
+* Improve performance of `RefinedType#unsafeFrom`.
+  ([#499][#499] by [@fthomas][@fthomas])
+
 [#486]: https://github.com/fthomas/refined/pull/486
 [#492]: https://github.com/fthomas/refined/pull/492
+[#499]: https://github.com/fthomas/refined/pull/499
 
 [@fthomas]: https://github.com/fthomas
 [@sh0hei]: https://github.com/sh0hei

project/plugin-jmh.sbt

@@ -1 +1 @@
-addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.3.0")
+addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.3.3")