Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MatchesRegex ==> NonEmpty inference #1002

Merged

Conversation

andreamarcolin
Copy link
Contributor

Didn't add tests for Scala 3, see #928

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #1002 (3faf9c4) into master (d012189) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   92.39%   92.40%           
=======================================
  Files          63       63           
  Lines         815      816    +1     
  Branches        6       10    +4     
=======================================
+ Hits          753      754    +1     
  Misses         62       62           
Impacted Files Coverage Δ
...rc/main/scala-3.0-/eu/timepit/refined/string.scala 98.79% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d012189...3faf9c4. Read the comment docs.

Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @andreamarcolin!

@fthomas fthomas merged commit 0e2654d into fthomas:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants