Restore some Native builds #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 63 63
Lines 832 832
Branches 10 10
=======================================
Hits 771 771
Misses 61 61 Continue to review full report at Codecov.
|
|
Thanks for releasing! :) |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1090.
This restores the Native builds for core, scalacheck, and shapeless modules. This is sufficient to unblock Circe Native.
There was a boxing related bug when running the Cats tests, so no Native for that today. Scodec could also get Native in the future (bits is cross-published, but not core yet).