-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pureconfig for scala3 [fixes fthomas/refined#1092] #1162
Conversation
Thanks for the PR, @ivan-klass! The Scala 3 build failed with:
|
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
+ Coverage 92.66% 92.69% +0.02%
==========================================
Files 63 65 +2
Lines 832 835 +3
Branches 26 29 +3
==========================================
+ Hits 771 774 +3
Misses 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Linking #1092 to this (I wonder why PR title doesn't work as described by docs |
The CI checks this with MiMa. I just checked this locally again to make sure that it is compatible:
Seems to be fine. |
...g/shared/src/main/scala-3.0-/eu/timepit/refined/pureconfig/TypeDescribeVersionSpecific.scala
Show resolved
Hide resolved
...g/shared/src/main/scala-3.0+/eu/timepit/refined/pureconfig/TypeDescribeVersionSpecific.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks again, @ivan-klass!
Added
ConfigReader
andConfigWriter
for refined typesI've kept 2.13 signature as is in order to keep binary compatibility - I'll be happy if one can help checking if it is actually maintained.
Also, now refined
ConfigReader
andConfigWriter
can be obtained independently fromConfigConvert
(more basic instances have lower priority when resolving).I tend to think that
ConfigWriter
is used much more rarely in practice thenConfigReader
. But with previous code it was impossible to getConfigReader[T Refined P]
if you only haveConfigReader[T]
but noConfigWriter[T]