Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Macro that generates companion for refined types #346

Closed
wants to merge 7 commits into from

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Oct 25, 2017

This is the second draft of a macro for #342 and still WIP.

@codecov
Copy link

codecov bot commented Nov 9, 2017

Codecov Report

Merging #346 into master will decrease coverage by 3.73%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   98.71%   94.97%   -3.74%     
==========================================
  Files          39       40       +1     
  Lines         468      478      +10     
  Branches        8        8              
==========================================
- Hits          462      454       -8     
- Misses          6       24      +18
Impacted Files Coverage Δ
...src/main/scala/eu/timepit/refined/types/char.scala 0% <0%> (ø)
.../main/scala/eu/timepit/refined/types/numeric.scala 0% <0%> (ø)
.../src/main/scala/eu/timepit/refined/types/net.scala 0% <0%> (ø)
...c/main/scala/eu/timepit/refined/types/string.scala 0% <0%> (ø)
...ala-2.13.0-M2/eu/timepit/refined/api/Refined.scala 75% <0%> (-13.89%) ⬇️
...hared/src/main/scala/eu/timepit/refined/eval.scala 100% <0%> (ø) ⬆️
.../scala/eu/timepit/refined/macros/RefineMacro.scala 100% <0%> (ø) ⬆️
...in/scala-2.11/eu/timepit/refined/api/Refined.scala
...in/scala-2.10/eu/timepit/refined/api/Refined.scala
...n/scala/eu/timepit/refined/macros/InferMacro.scala
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bb5b4...35703d9. Read the comment docs.

@fthomas
Copy link
Owner Author

fthomas commented Nov 10, 2017

The current implementation works with 2.12 but not with 2.10 and 2.11. And unfortunately both fail in different ways and I've no idea how to fix them.

@fthomas
Copy link
Owner Author

fthomas commented Dec 17, 2017

Closing in favor of #369.

@fthomas fthomas closed this Dec 17, 2017
@fthomas fthomas deleted the topic/RefinedCompanion branch December 17, 2017 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant