Add IPv4 and private networks #356
Conversation
NeQuissimus
force-pushed
the
ip_networks
branch
from
89bc8d9
to
987b879
Compare
| @@ -40,14 +43,34 @@ object string extends StringValidate with StringInference { | |||
| final case class XPath() | |||
| } | |||
|
|
|||
| private[refined] trait StringValidate { | |||
| object Predicates { | |||
| object IPv4 { | |||
There was a problem hiding this comment.
Could you move the IPv4 object into the string object right below the IPv4 case class and remove the Predicates object? It makes sense to put auxiliary code of predicates into their proper companion.
|
|
||
| /** A `String` representing a valid IPv4 in a private network according to RFC1918 */ | ||
| type Rfc1918Private = | ||
| String Refined Rfc1918ClassAPrivateSpec Or Rfc1918ClassBPrivateSpec Or Rfc1918ClassCPrivateSpec |
There was a problem hiding this comment.
Would it make sense to add an alias type Rfc1918PrivateSpec = Rfc1918ClassAPrivateSpec Or Rfc1918ClassBPrivateSpec Or Rfc1918ClassCPrivateSpec? That could be used here and in the definition of PrivateNetwork. A type Rfc5737TestnetSpec could be also useful to avoid repetition.
NeQuissimus
force-pushed
the
ip_networks
branch
from
987b879
to
f8e23af
Compare
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 98.71% 98.74% +0.02%
==========================================
Files 39 39
Lines 468 478 +10
Branches 8 8
==========================================
+ Hits 462 472 +10
Misses 6 6
Continue to review full report at Codecov.
|
|
Looks great, many thanks @NeQuissimus! |
Basically a follow-up to #353
This is what I am using at work, I figured I would clean it up and contribute it back.
No external Java dependencies, so this also works with Scala.js without any issues.
I will have to add IPv6 next week, so I will send that in as well once I have it.
/cc @derekmorr @fthomas