Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following string predicates:
ValidInt
,ValidLong
,ValidDouble
,ValidBigInt
, andValidBigDecimal
.I initially implemented this with a typeclass-based approach, e.g.
ParsableString[N]
, which theValidate
instance would use, but it seemed to be double the work than just creating new predicates and the correspondingValidate
instances. Both seem extensible enough, though I surmise that a typeclass-based approach would be a little less verbose, since supplying the typeclass instances would be enough to get started. @fthomas, if you think that that's a more sensible approach, then I can always update this PR.I'm also thinking of adding inference instances for these, but I'll hold off for now until I can find a good way of doing it without copious amounts of copy and paste.