Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicates package and über-import for all predicates #433

Merged
merged 4 commits into from
Feb 3, 2018

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Feb 3, 2018

This allows to import all predicates with import predicates.all._. The AllPredicates trait also allow us to create an even bigger über-import. It is one step towards #184.

With a predicates package it also makes sense to move the actual definitions of our predicates here. But that should happen in another PR.

@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #433 into master will decrease coverage by 1.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   98.84%   97.56%   -1.28%     
==========================================
  Files          51       57       +6     
  Lines         605      658      +53     
  Branches       12       12              
==========================================
+ Hits          598      642      +44     
- Misses          7       16       +9
Impacted Files Coverage Δ
.../scala/eu/timepit/refined/predicates/numeric.scala 100% <100%> (ø)
...ala/eu/timepit/refined/predicates/collection.scala 100% <100%> (ø)
.../scala/eu/timepit/refined/predicates/boolean.scala 100% <100%> (ø)
.../scala/eu/timepit/refined/predicates/generic.scala 100% <100%> (ø)
...ain/scala/eu/timepit/refined/predicates/char.scala 100% <100%> (ø)
...n/scala/eu/timepit/refined/predicates/string.scala 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59d2b7...466ae3d. Read the comment docs.

@fthomas fthomas merged commit d09b5bf into master Feb 3, 2018
@fthomas fthomas deleted the topic/predicates-pkg branch February 3, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant