-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of #447 for Cats #449
Conversation
Damn. How do you want to do the 2.11+ restriction? I'm not sure how to do that in your codebase. |
The first commit in this PR failed on all Scala versions with:
Commenting out a seemingly unrelated test in bdc0b26 fixed the 2.11+ builds while the 2.10 build still fails with that error. |
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 98.01% 96.75% -1.27%
==========================================
Files 57 57
Lines 655 677 +22
Branches 12 12
==========================================
+ Hits 642 655 +13
- Misses 13 22 +9
Continue to review full report at Codecov.
|
That is the easiest way to ignore that test with Scala 2.10
@fommil The easiest option to make #447 2.11+ only would be to not run the tests with 2.10. In this PR I choose to run the test for |
Ok great, but the addition of the implicit is breaking one of the existing tests in a way I don't understand. |
I'm also okay with not running |
great! So how do we do that from a practical point of view? I'm not sure how to disable a test. |
Moving the test file from refined/modules/scalaz/shared/src/test/scala/eu/timepit/refined/scalaz/ to refined/modules/scalaz/shared/src/test/scala-2.12/eu/timepit/refined/scalaz/ does the trick. |
Will you cut a release soon with these new things? |
I'll want to process some of the open PRs and need to update the release notes before cutting the next release. That will probably take me one or two weeks. |
This is a port of #447 for Cats. One reason for doing this is to see if the 2.10 build fails in a similar way.
/cc @fommil