Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest travis_setup.sh for Scala Native #458

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Update to the latest travis_setup.sh for Scala Native #458

merged 1 commit into from
Mar 24, 2018

Conversation

densh
Copy link
Contributor

@densh densh commented Mar 24, 2018

Recent PR changed the location of the travis setup script within a Scala Native repo. This PR updates travis build to point to the new location.

[Recent PR](scala-native/scala-native#1195) changed the location of the travis setup script within a Scala Native repo. This PR updates travis build to point to the new location.
@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          57       57           
  Lines         662      662           
  Branches       12       12           
=======================================
  Hits          649      649           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acf602...7c06b67. Read the comment docs.

@fthomas
Copy link
Owner

fthomas commented Mar 24, 2018

Thanks @densh! Will the script in the master branch work for all versions of Scala Native or should we change to a tagged version of that script on the next Scala Native release (e.g. https://raw.githubusercontent.com/scala-native/scala-native/v0.3.7/scripts/travis_setup.sh)?

@fthomas fthomas merged commit 46757b6 into fthomas:master Mar 24, 2018
@densh
Copy link
Contributor Author

densh commented Mar 24, 2018

@fthomas We plan to slowly shrink number of external dependencies in the future, but it's not happening any time soon, so using master is quite safe. We also update it whenever travis environment changes. In any case if you have any issues with travis setup script just let us know on gitter.

@fthomas
Copy link
Owner

fthomas commented Mar 27, 2018

Ok, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants