Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generic derivation instances to fix "diverging implicit expansion" errors #554

Merged
merged 9 commits into from
Nov 3, 2018

Conversation

fthomas
Copy link
Owner

@fthomas fthomas commented Aug 6, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #554 into master will decrease coverage by 0.52%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   93.61%   93.08%   -0.53%     
==========================================
  Files          63       65       +2     
  Lines         705      709       +4     
  Branches       11       11              
==========================================
  Hits          660      660              
- Misses         45       49       +4
Impacted Files Coverage Δ
...ain/scala/eu/timepit/refined/cats/derivation.scala 100% <100%> (ø)
...n/scala/eu/timepit/refined/scalaz/derivation.scala 100% <100%> (ø)
...main/scala/eu/timepit/refined/scalaz/package.scala 75% <50%> (-25%) ⬇️
...c/main/scala/eu/timepit/refined/cats/package.scala 60% <60%> (-40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb819d7...f9e7a29. Read the comment docs.

@fthomas fthomas changed the title Reproduce #553 Move generic derivation instances to fix "diverging implicit expansion" errors Nov 3, 2018
@fthomas fthomas merged commit c0c7a62 into master Nov 3, 2018
@fthomas fthomas deleted the topic/fix-553 branch November 4, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant