Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric refined types for Byte, Short, BigInt and BigDecimal. #567

Merged
merged 6 commits into from
Sep 14, 2018

Conversation

Michaelt293
Copy link
Contributor

Added numeric refined types for Byte, Short, BigInt and BigDecimal.

@Michaelt293 Michaelt293 changed the title Numeric refined types for Byte, Short, BigInt and BigDecimal. WIP: Numeric refined types for Byte, Short, BigInt and BigDecimal. Sep 13, 2018
@fthomas
Copy link
Owner

fthomas commented Sep 14, 2018

Thanks for the PR, @Michaelt293! To make this change binary compatible forwarders of all new types must be added to NumericTypesBinCompat1 and it cannot be mixed into NumericTypes. In types/all.scala you then need a new trait:

trait AllTypesBinCompat1 extends NumericTypesBinCompat1

which is then mixed into the allobject. We have a similar situation here: https://github.com/fthomas/refined/blob/master/modules/core/shared/src/main/scala/eu/timepit/refined/predicates/all.scala

@Michaelt293 Michaelt293 changed the title WIP: Numeric refined types for Byte, Short, BigInt and BigDecimal. Numeric refined types for Byte, Short, BigInt and BigDecimal. Sep 14, 2018
@Michaelt293
Copy link
Contributor Author

Thanks for your help @fthomas. Was very helpful :)

Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again, @Michaelt293!

@fthomas fthomas merged commit 50a6981 into fthomas:master Sep 14, 2018
@fthomas fthomas mentioned this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants