Fix loadPaletteGrayscale()
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `loadPaletteGrayscale()` is broken. It returns a palette containing `[(0, 0, 0)x255, (1, 1, 1)]`. If you use any number of steps other the default 256 steps, you don't even get the `(1, 1, 1)`.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
loadPaletteGrayscale()is broken. It returns a palette containing[(0, 0, 0)x255, (1, 1, 1)]. If you use any number of steps other the default 256 steps, you don't even get the(1, 1, 1).There are some small things you might want to change, such as the implicit move from
float32tofloat64in the division and the fact that(255, 255, 255)will never be in the palette unless you use the full 256 steps, but at the very least, let's fix the function please :)