Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add cmake support for qt6 #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dabbinavo
Copy link

@dabbinavo dabbinavo commented Dec 29, 2021

features:

fixes:

  • revert minimum required cmake version to 3.2 (was incremented accidentally in commit ebb3e5e)
  • remove duplicate compile definitions for 1D barcode support
  • include qt components multimedia, svg, quick and quickcontrols2 only when neccessary

Copy link

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but has some issues. please fix.

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
features:
- add option to specify target qt version
- dynamically locate QT version and use version specific components and linker targets (also see https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older-qt-5-versions)

fixes:
- revert minimum required cmake version to 3.2 (was incremented accidentally in commit ebb3e5e)
- remove duplicate compile definitions for 1D barcode support
- include qt components multimedia, svg, quick and quickcontrols2 only when neccessary
Copy link

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. But i can't check build manually

@dabbinavo
Copy link
Author

looks good for me. But i can't check build manually

@EndrII, what do you mean by "can't check build manually"

I successfully build the library for Qt5.15.2 and Qt6.2.2 with the following settings (total of 4 builds):

Build A

cmake_minimum_required(VERSION 3.2)

project(test)

SET(QZXING_MULTIMEDIA ON)
SET(QZXING_USE_DECODER_1D_BARCODES ON)
SET(QZXING_USE_DECODER_QR_CODE ON)
add_subdirectory(ext/qzxing/src)

Build B

cmake_minimum_required(VERSION 3.2)

project(test)

SET(QZXING_USE_ENCODER ON)
add_subdirectory(ext/qzxing/src)

@EndrII
Copy link

EndrII commented Dec 29, 2021

Where are BOSS of this project ?)
@ftylitak please check this PR and merge if all is good.

@dabbinavo
Copy link
Author

@ftylitak anything missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants