Update interface.ts #910
Open
Update interface.ts #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import statement for ChatCompletionRequestMessage is unnecessary if it's not used within this file. The IConfig interface has a required property openai_api_key, but api is optional. It might be preferable to make openai_api_key optional as well for more flexibility. The User interface defines chatMessage as an array of ChatCompletionRequestMessage, but it seems like ChatCompletionRequestMessage is an import rather than a defined interface or type. There are no comments to explain the purpose of each interface or any other parts of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import statement for ChatCompletionRequestMessage is unnecessary if it's not used within this file. The IConfig interface has a required property openai_api_key, but api is optional. It might be preferable to make openai_api_key optional as well for more flexibility. The User interface defines chatMessage as an array of ChatCompletionRequestMessage, but it seems like ChatCompletionRequestMessage is an import rather than a defined interface or type. There are no comments to explain the purpose of each interface or any other parts of the code.